Messages in this thread | | | Date | Sun, 23 Mar 2014 20:39:25 -0700 | From | Guenter Roeck <> | Subject | Re: [RFC V1 1/3] hwmon: da9063: HWMON driver |
| |
On 03/23/2014 01:37 PM, Opensource [Steve Twiss] wrote: > From: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com> > > Add the HWMON driver for DA9063 > > Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com> > --- > Checks performed with linux-next/next-20140321/scripts/checkpatch.pl > da9063-hwmon.c total: 0 errors, 0 warnings, 456 lines checked > Kconfig total: 1 errors, 3 warnings, 1643 lines checked > Makefile total: 0 errors, 0 warnings, 154 lines checked > registers.h total: 0 errors, 0 warnings, 1066 lines checked > There are errors and warning in Kconfig, however they are not caused > by this patch. > > This is the hardware monitor driver component for DA9063 PMIC. > > The manual measurement allows monitoring of the system voltage > VSYS, the auxiliary channels ADCIN1, ADCIN2 and ADCIN3, VBBAT > measures of the backup battery voltage and a Tjunc value for the > internal junction temperature sensor. >
At least this part belongs into the summary.
After browsing through patch 2/3, I got suspicious and tried to compile the driver after applying this patch.
Here is the result:
drivers/hwmon/da9063-hwmon.c: In function 'da9063_adc_manual_read': drivers/hwmon/da9063-hwmon.c:155:2: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] drivers/hwmon/da9063-hwmon.c: In function 'da9063_hwmon_probe': drivers/hwmon/da9063-hwmon.c:386:14: error: 'struct da9063_pdata' has no member named 'hwmon_pdata' drivers/hwmon/da9063-hwmon.c:387:14: error: 'struct da9063_pdata' has no member named 'hwmon_pdata' drivers/hwmon/da9063-hwmon.c:388:14: error: 'struct da9063_pdata' has no member named 'hwmon_pdata' drivers/hwmon/da9063-hwmon.c:417:50: error: 'struct da9063' has no member named 't_offset' make[1]: *** [drivers/hwmon/da9063-hwmon.o] Error 1 make: *** [drivers/hwmon/da9063-hwmon.ko] Error 2
Please make sure that each patch, if applied one after another, compiles. Patch 1/3 must not depend on patch 2/3.
Thanks, Guenter
| |