Messages in this thread | | | Date | Fri, 21 Mar 2014 13:36:31 +0900 | Subject | Re: [PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree | From | DaeSeok Youn <> |
| |
2014-03-21 13:27 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>: > On Fri, Mar 21, 2014 at 01:15:23PM +0900, Daeseok Youn wrote: >> >> Replace OS_kmalloc/OS_kfree with kmalloc/kfree. > > You should replace it with kzalloc, not kmalloc, as OS_kmalloc() zeroed > out the allocated data:
I think some case does not need to get zeroed memory. :-) I will change that and send it again.
Thanks for review. Daeseok Youn.
> > >> -static inline void * >> -OS_kmalloc (size_t size) >> -{ >> - char *ptr = kmalloc (size, GFP_KERNEL | GFP_DMA); >> - >> - if (ptr) >> - memset (ptr, 0, size); >> - return ptr; >> -} > > greg k-h
| |