lkml.org 
[lkml]   [2014]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix some coding style in drivers/staging/iio
[...]
> diff --git a/drivers/staging/iio/accel/adis16220_core.c b/drivers/staging/iio/accel/adis16220_core.c
> index 6f38ca9..31c7a9d 100644
> --- a/drivers/staging/iio/accel/adis16220_core.c
> +++ b/drivers/staging/iio/accel/adis16220_core.c
> @@ -392,7 +392,8 @@ static const struct iio_info adis16220_info = {
> };
>
> static const char * const adis16220_status_error_msgs[] = {
> - [ADIS16220_DIAG_STAT_VIOLATION_BIT] = "Capture period violation/interruption",
> + [ADIS16220_DIAG_STAT_VIOLATION_BIT] =
> + "Capture period violation/interruption",

This does not improve legibility. The 80 chars per line rule is to improve
legibility, if it doesn't it's better to ignore it.

> [ADIS16220_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure",
> [ADIS16220_DIAG_STAT_FLASH_UPT_BIT] = "Flash update failed",
> [ADIS16220_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V",
[...]
> diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c
> index 36eedd8..d38df2e 100644
> --- a/drivers/staging/iio/resolver/ad2s1200.c
> +++ b/drivers/staging/iio/resolver/ad2s1200.c
> @@ -70,6 +70,7 @@ static int ad2s1200_read_raw(struct iio_dev *indio_dev,
> vel = (((s16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4);
> vel = (vel << 4) >> 4;
> *val = vel;
> + /* fall through */

This not a coding style issue, here is actually a break missing.

> default:
> mutex_unlock(&st->lock);
> return -EINVAL;
>



\
 
 \ /
  Last update: 2014-03-21 09:21    [W:0.056 / U:2.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site