Messages in this thread | | | Date | Fri, 21 Mar 2014 14:39:44 -0300 | From | Eduardo Habkost <> | Subject | Re: [PATCH v2 1/4] KVM: ioapic: merge ioapic_deliver into ioapic_service |
| |
On Fri, Mar 21, 2014 at 10:27:58AM +0100, Paolo Bonzini wrote: > Commonize the handling of masking, which was absent for kvm_ioapic_set_irq. > Setting remote_irr does not need a separate function either, and merging > the two functions avoids confusion. > > Reviewed-by: Alex Williamson <alex.williamson@redhat.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Just code movement, no functional changes.
(The change from entry->fields.trig_mode to irqe.trig_mode is not purely code movement, but kvm_irq_delivery_to_apic() doesn't change irq->trig_mode, so it's OK).
-- Eduardo
| |