Messages in this thread | | | Subject | Re: [PATCH 2/2] coding style: fix line over 80 characters | From | Joe Perches <> | Date | Thu, 20 Mar 2014 13:45:14 -0700 |
| |
On Fri, 2014-03-21 at 00:34 +0300, Sergei Shtylyov wrote: > On 03/20/2014 01:04 AM, Cédric Cabessa wrote: > > diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c [] > > @@ -271,12 +271,14 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, > > } > > break; > > case USB_PORT_FEAT_POWER: > > - usbip_dbg_vhci_rh(" ClearPortFeature: USB_PORT_FEAT_POWER\n"); > > + usbip_dbg_vhci_rh( > > + " ClearPortFeature: USB_PORT_FEAT_POWER\n"); > > Your version of scripts/checkpatch.pl seems outdated. It shouldn't > complain about strings violating 80-column limit (and I've just verified it > doesn't).
checkpatch complains about > 80 char lines for lines with a function where the function name isn't understood to be a logging use.
uspip_dbg_<foo> doesn't take the general form so if the string at the EOL exceeds 80 chars, a message is emitted.
Long standalone strings on a single line do not get warnings.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |