lkml.org 
[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2a 1/2] dt: Document a compatible entry for MDIO ethernet Phys
On Thu, Mar 20, 2014 at 09:26:28AM +0100, Ben Dooks wrote:

> >+ If the phy's identifier is known then the list may contain an entry
> >+ of the form: "ethernet-phy-idAAAA.BBBB" where
> >+ AAAA - The value of the 16 bit Phy Identifier 1 register as
> >+ 4 hex digits. This is the chip vendor OUI bits 3:18
> >+ BBBB - The value of the 16 bit Phy Identifier 2 register as
> >+ 4 hex digits. This is the chip vendor OUI bits 19:24,
> >+ followed by 10 bits of a vendor specific ID.
> >+
>
> How about having "ethernet-phy" and adding a single property in the
> PHY node saying phy-id = <AAAABBBB>, which would be much easier to
> parse.

That option was discussed (and my first patch was this way)..

However, using the compatible string is consistent with other OF
schemes, such as PCI which uses compatible strings like pciVVVV,DDDD
pciclass,CCSS and so on.

It does make a fair amount sense because the purpose of compatible is
to identify the device.

Jason


\
 
 \ /
  Last update: 2014-03-20 18:21    [W:0.054 / U:7.924 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site