lkml.org 
[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] x86, vdso32: fix out of memory handling setup vDSO
On Thu, Mar 20, 2014 at 8:15 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Thu, 20 Mar 2014, Andy Lutomirski wrote:
>> On Thu, Mar 20, 2014 at 5:30 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>> > On Thu, 20 Mar 2014, Stefani Seibold wrote:
>> >> All complains are design decisions not made by me. I will send a patch
>> >> for the GFP_ATOMIC thing. For the other one it would be the best to ask
>> >> Andy for the reason.
>> >
>> > I'm not saying it's your fault, but if we rework code, then we really
>> > should question such things. What happens if you remove the x32 call
>> > and make the x64 subsys thing valid for both cases?
>> >
>>
>> It's not just that. The x86_64 and x32 vdso page arrays are *far*
>> cleaner than the 32-bit variant. They manage to do the entire vdso
>> setup dance without any allocation at all. This avoids silly
>> questions about error handling and GFP_KERNEL :)
>>
>> See vdso/vdso.S for the rather small amount of magic needed.
>
> Is there any reason why we can't use that for x86_32 ?
>

Not really. I'll play with it a bit.

> Thanks,
>
> tglx



--
Andy Lutomirski
AMA Capital Management, LLC


\
 
 \ /
  Last update: 2014-03-20 17:41    [W:1.109 / U:1.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site