Messages in this thread | | | Date | Thu, 20 Mar 2014 15:51:19 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v6 36/36] ARM: STi: Add support for the FSM Serial Flash Controller |
| |
> > Here we add the necessary device nodes required for successful device > > probing and Pinctrl setup for the FSM. > > > > Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com> > > Acked-by Angus Clark <angus.clark@st.com> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > arch/arm/boot/dts/stih416-pinctrl.dtsi | 13 +++++++++++++ > > arch/arm/boot/dts/stih416.dtsi | 13 +++++++++++++ > > arch/arm/boot/dts/stih41x-b2020.dtsi | 1 + > > arch/arm/boot/dts/stih41x-b2020x.dtsi | 28 ++++++++++++++++++++++++++++ > > 4 files changed, 55 insertions(+) > > create mode 100644 arch/arm/boot/dts/stih41x-b2020x.dtsi
[...]
> > + soc { > > + spifsm: spifsm@fe902000 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + status = "okay"; > > + > > + partition@0 { > > + label = "Serial Flash 1"; > > Are you sure you want spaces in the partition label? I suppose MTD can > probably handle this fine, but it doesn't seem standard, and it may > prevent you from using the partition name in certain ways. For instance, > it might make it harder to use with the "ubi.mtd=" module parameter. > > But otherwise: > > Acked-by: Brian Norris <computersforpeace@gmail.com>
Code fixed and Ack applied.
Thanks Brian.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |