lkml.org 
[lkml]   [2014]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] aio: fix the confliction of read events and migrating ring page
On Thu, Mar 20, 2014 at 01:46:25PM +0800, Gu Zheng wrote:

> diff --git a/fs/aio.c b/fs/aio.c
> index 88ad40c..e353085 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -319,6 +319,9 @@ static int aio_migratepage(struct address_space *mapping, struct page *new,
> ctx->ring_pages[old->index] = new;
> spin_unlock_irqrestore(&ctx->completion_lock, flags);
>
> + /* Ensure read event is completed before putting old page */
> + mutex_lock(&ctx->ring_lock);
> + mutex_unlock(&ctx->ring_lock);
> put_page(old);
>
> return rc;

This looks a bit weird. Would using a completion work here ?

Dave



\
 
 \ /
  Last update: 2014-03-20 16:21    [W:0.091 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site