lkml.org 
[lkml]   [2014]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)
Date


> -----Original Message-----
> > +
> > +
> > +/* ndis_recv_scale_cap/cap_flag */
>
> One empty line is sufficient, we don't need two of them here.

I will fix this and other formats you pointed out below, also check the whole patch
for similar issues.

> > - net = alloc_etherdev(sizeof(struct net_device_context));
> > + net = alloc_etherdev_mq(sizeof(struct net_device_context),
> > + num_online_cpus());
> > if (!net)
> > return -ENOMEM;
> >
>
> num_online_cpus() can change, will your driver accomodate this?

HyperV currently doesn't support hot-add/remove cpu, so this is constant for
this driver.

Thanks,
- Haiyang


\
 
 \ /
  Last update: 2014-03-19 23:41    [W:0.070 / U:2.020 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site