lkml.org 
[lkml]   [2014]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
On 03/19/2014 09:38 PM, Zoltan Kiss wrote:
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well.
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
> ---

> + if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
> + skb_tx_error(to);
> + return -ENOMEM;
> }

I think you should move this down to right before we iterate over the
frags.

Looks good otherwise.


\
 
 \ /
  Last update: 2014-03-19 22:21    [W:0.029 / U:28.960 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site