[lkml]   [2014]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] Add check for Change-Id
A commit hook for the Gerrit code review server inserts change
identifiers so Gerrit can track patches through multiple revisions.
These identifiers are noise in the context of the upstream kernel.
(Many Gerrit servers are private. Even given a public instance,
given only a Change-Id, one must guess which server a change was
tracked on. Patches submitted to the Linux kernel mailing lists
should be able to stand on their own. If it's truly useful to
reference code review on a Gerrit server, a URL is a much clearer
way to do so.) Thus, issue an error when a Change-Id: line is

Signed-off-by: Christopher Covington <>
scripts/ | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/scripts/ b/scripts/
index 464dcef..afd6dde 100755
--- a/scripts/
+++ b/scripts/
@@ -1891,6 +1891,12 @@ sub process {

+# Check for unwanted Gerrit info
+ if ($line =~ /^\s*change-id:/i) {
+ "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
+ }
# Check for wrappage within a valid hunk of the file
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by the Linux Foundation.

 \ /
  Last update: 2014-03-19 20:41    [W:0.047 / U:141.220 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site