lkml.org 
[lkml]   [2014]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/13] perf tools: Use tid in mmap/mmap2 events to find maps
On 19/03/2014 4:43 p.m., Don Zickus wrote:
> On Wed, Mar 19, 2014 at 04:27:25PM +0200, Adrian Hunter wrote:
>> On 19.03.2014 15:30, Jiri Olsa wrote:
>>> On Wed, Mar 19, 2014 at 09:19:45AM -0400, Don Zickus wrote:
>>>> On Wed, Mar 19, 2014 at 09:13:38AM +0200, Adrian Hunter wrote:
>>>>> On 18.03.2014 23:25, Arnaldo Carvalho de Melo wrote:
>>>>>> From: Don Zickus <dzickus@redhat.com>
>>>>>>
>>>>>> Now that we can properly synthesize threads system-wide, make sure the
>>>>>> mmap and mmap2 events use tids instead of pids to locate their maps.
>>>>>
>>>>> This is a good change but it cannot go yet because it is dependent on Jiri's
>>>>> "perf tools: Share map groups within process" series.
>>>>
>>>> No it isn't. :-) Commit bfd66cc71a3f831ba7c2116d79416cfb8883f6cf is the
>>>> reason why. It synthesizes thread events to make this work correctly.
>>>
>>> ok, I haven't realized this one was pulled in as well ;-)
>>> it's ok then..
>>
>> No, you mustn't split up the maps between threads. We currently assume
>> CLONE_VM is always used to create threads.
>
> But that doesn't work when you try to synthesize threads which was the
> problem I was trying to solve.

It worked if you looked up the maps on the pid not the tid.


\
 
 \ /
  Last update: 2014-03-19 17:01    [W:0.093 / U:8.208 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site