Messages in this thread | | | Date | Wed, 19 Mar 2014 10:43:53 -0400 | From | Don Zickus <> | Subject | Re: [PATCH 06/13] perf tools: Use tid in mmap/mmap2 events to find maps |
| |
On Wed, Mar 19, 2014 at 04:27:25PM +0200, Adrian Hunter wrote: > On 19.03.2014 15:30, Jiri Olsa wrote: > > On Wed, Mar 19, 2014 at 09:19:45AM -0400, Don Zickus wrote: > >> On Wed, Mar 19, 2014 at 09:13:38AM +0200, Adrian Hunter wrote: > >>> On 18.03.2014 23:25, Arnaldo Carvalho de Melo wrote: > >>>> From: Don Zickus <dzickus@redhat.com> > >>>> > >>>> Now that we can properly synthesize threads system-wide, make sure the > >>>> mmap and mmap2 events use tids instead of pids to locate their maps. > >>> > >>> This is a good change but it cannot go yet because it is dependent on Jiri's > >>> "perf tools: Share map groups within process" series. > >> > >> No it isn't. :-) Commit bfd66cc71a3f831ba7c2116d79416cfb8883f6cf is the > >> reason why. It synthesizes thread events to make this work correctly. > > > > ok, I haven't realized this one was pulled in as well ;-) > > it's ok then.. > > No, you mustn't split up the maps between threads. We currently assume > CLONE_VM is always used to create threads.
But that doesn't work when you try to synthesize threads which was the problem I was trying to solve.
Cheers, Don
| |