Messages in this thread | | | Subject | Re: [PATCH-next] mfd/rtc: s5m: Do not allocate RTC I2C dummy and regmap for unsupported chipsets | From | Krzysztof Kozlowski <> | Date | Wed, 19 Mar 2014 13:50:41 +0100 |
| |
On Wed, 2014-03-19 at 12:47 +0000, Lee Jones wrote: > > The rtc-s5m driver does not support all of S2M and S5M chipsets > > supported by main MFD sec-core driver. For such chipsets unsupported by > > rtc-s5m, the MFD sec-core driver initialized regmap with default config. > > This config in such cases wouldn't work at all. > > > > The main MFD sec-core driver shouldn't initialize regmap for child > > drivers which is not used by them and even not valid. > > > > Move the allocation of RTC I2C dummy device and initialization of RTC > > regmap from main MFD sec-core driver to the rtc-s5m driver. The rtc-s5m > > driver will use proper regmap config for supported devices. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > drivers/mfd/sec-core.c | 53 +-------------------------- > > drivers/rtc/rtc-s5m.c | 75 +++++++++++++++++++++++++++++++++++--- > > include/linux/mfd/samsung/core.h | 3 -- > > 3 files changed, 71 insertions(+), 60 deletions(-) > > It's a bit late in the cycle for this kind of change. Would you mind > re-sending after the v3.15 merge window please?
Sure, no problem.
Best regards, Krzysztof
| |