lkml.org 
[lkml]   [2014]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links
On 03/18/2014 10:17 AM, Jean-Francois Moine wrote:
> On Mon, 17 Mar 2014 16:43:39 +0000
> Mark Brown <broonie@kernel.org> wrote:
>
>> On Sat, Mar 15, 2014 at 12:30:05PM +0100, Jean-Francois Moine wrote:
> [snip]
...

>
> I agree. I see two possible syntaxes:
>
> 1) keep the same definitions in the containers:
>
> sound {
> compatible = "simple-audio-card";
> simple-audio-card,name = "Cubox Audio";
>
> simple-audio-card,dai-link@0 { /* I2S - HDMI */
> simple-audio-card,cpu {
> sound-dai = <&audio1 0>;
> format = "i2s";
> };
> simple-audio-card,codec {
> sound-dai = <&tda998x 0>;
> };
> };
>
> simple-audio-card,dai-link@1 { /* S/PDIF - HDMI */
> simple-audio-card,cpu {
> sound-dai = <&audio1 1>;
> };
> simple-audio-card,codec {
> sound-dai = <&tda998x 1>;
> }
> };
> ...
>

I vote for the version above. As Mark said there is need for dai
specific properties.

While we are at it we could update the bitclock-master and frame-master
syntax to be like this:

bitclock-master = "cpu"
frame-master = "codec"

With the above explicit definition all the daifmt settings could be
defined in link level. For backwards compatibility we could still define
that omitting the value equals "codec" and omitting the property equals
"cpu".

It may sometimes be helpful to allow overwriting link level settings in
dai level. In order to do that it should be possible to write all daifmt
settings explicitly like this:

bitclock-inversion = <0>; /* <0> = no bitclock-inversion */

If backward compatibility is necessary we could recognize the syntax
version from the existence dai-link node.

sound {
compatible = "simple-audio-card";
simple-audio-card,name = "Simple Audio";
simple-audio-card,widgets = ...
simple-audio-card,routing = ...

simple-audio-card,dai-link@0 { /* I2S - codec */
format = "i2s";
bitclock-master = "codec";
frame-master = "codec";
bitclock-inversion = <1>;
simple-audio-card,cpu {
sound-dai = <&audio1 0>;
bitclock-inversion = <0>;
};
simple-audio-card,codec {
sound-dai = <&codec 0>;
system-clock-frequency = <12000000>;
};
};
...

I can participate in the implementation too.

Best regards,
Jyro


\
 
 \ /
  Last update: 2014-03-19 11:41    [W:0.084 / U:1.844 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site