lkml.org 
[lkml]   [2014]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core
On Tue, Mar 18, 2014 at 05:44:30PM +0000, Mark Brown wrote:
> On Tue, Mar 18, 2014 at 05:22:31PM +0000, Charles Keepax wrote:
>
> > - /*
> > - * LDO1 can only be used to supply DCVDD so if it has no
> > - * consumers then DCVDD is supplied externally.
> > - */
> > - if (arizona->pdata.ldo1 &&
> > - arizona->pdata.ldo1->num_consumer_supplies == 0)
> > - arizona->external_dcvdd = true;
> > -
>
> Actually now that I look at this again one issue here - the reason this
> is in the core is that if the system is using an external DCVDD it may
> not be building the regulator driver at all (it won't do anything at
> runtime) so the flag would never get set if it's done by the regulator
> driver.

Ah... missed that. I will respin again.

Thanks,
Charles



\
 
 \ /
  Last update: 2014-03-19 10:41    [W:0.061 / U:0.408 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site