lkml.org 
[lkml]   [2014]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 3/6] fat: zero out seek range on _fat_get_block
Date
Namjae Jeon <linkinjeon@gmail.com> writes:

> +static void check_fallocated_region(struct inode *inode, sector_t iblock,
> + unsigned long *max_blocks, struct buffer_head *bh_result)
> +{
> + struct super_block *sb = inode->i_sb;
> + sector_t last_block, disk_block;
> + const unsigned long blocksize = sb->s_blocksize;
> + const unsigned char blocksize_bits = sb->s_blocksize_bits;
> +
> + last_block = (MSDOS_I(inode)->mmu_private + (blocksize - 1))
> + >> blocksize_bits;
> + disk_block = (MSDOS_I(inode)->i_disksize + (blocksize - 1))
> + >> blocksize_bits;
> + if (iblock >= last_block && iblock <= disk_block) {

Maybe off-by-one error. If iblock == disk_block, phys should not be set
by fat_bmap()?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


\
 
 \ /
  Last update: 2014-03-18 17:22    [W:0.176 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site