Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH v4 3/6] fat: zero out seek range on _fat_get_block | Date | Tue, 18 Mar 2014 23:59:14 +0900 |
| |
Namjae Jeon <linkinjeon@gmail.com> writes:
> +static void check_fallocated_region(struct inode *inode, sector_t iblock, > + unsigned long *max_blocks, struct buffer_head *bh_result) > +{ > + struct super_block *sb = inode->i_sb; > + sector_t last_block, disk_block; > + const unsigned long blocksize = sb->s_blocksize; > + const unsigned char blocksize_bits = sb->s_blocksize_bits; > + > + last_block = (MSDOS_I(inode)->mmu_private + (blocksize - 1)) > + >> blocksize_bits; > + disk_block = (MSDOS_I(inode)->i_disksize + (blocksize - 1)) > + >> blocksize_bits; > + if (iblock >= last_block && iblock <= disk_block) {
Maybe off-by-one error. If iblock == disk_block, phys should not be set by fat_bmap()? -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |