Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 5/5] perf tools: Share process map groups within process threads | Date | Mon, 17 Mar 2014 16:25:15 +0900 |
| |
On Fri, 14 Mar 2014 15:00:06 +0100, Jiri Olsa wrote: > + if (!mg) { > + struct thread *leader = thread__get_leader(thread); > + > + if (!leader) > + return NULL; > + > + if (leader->mg) > + mg = leader->mg; > + else > + mg = thread__map_groups_alloc(leader); > + > + if (leader != thread) > + thread->mg = mg; > + > + mg->refcnt++;
What's the value of mg->refcnt here in case of leader != thread and leader->mg was not allocated originally? I think it's 1 - but shouldn't it be 2 since it's referenced from both of leader and the thread now?
Thanks, Namhyung
| |