lkml.org 
[lkml]   [2014]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive Side Scaling (vRSS)
Date


> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Monday, March 17, 2014 4:20 PM
> To: Haiyang Zhang
> Cc: netdev@vger.kernel.org; KY Srinivasan; olaf@aepfle.de;
> jasowang@redhat.com; linux-kernel@vger.kernel.org; driverdev-
> devel@linuxdriverproject.org
> Subject: Re: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive
> Side Scaling (vRSS)
>
> From: Haiyang Zhang <haiyangz@microsoft.com>
> Date: Sat, 15 Mar 2014 10:18:07 -0700
>
> > - if (netif_queue_stopped(ndev) && !net_device->start_remove
> &&
> > - (hv_ringbuf_avail_percent(&device->channel-
> >outbound)
> > - > RING_AVAIL_PERCENT_HIWATER ||
> > - num_outstanding_sends < 1))
> > - netif_wake_queue(ndev);
> > + if (netif_tx_queue_stopped(netdev_get_tx_queue(ndev, q_idx))
> > + && !net_device->start_remove &&
> > + (hv_ringbuf_avail_percent(&channel->outbound)
> > + > RING_AVAIL_PERCENT_HIWATER || queue_sends <
> 1))
> > + netif_tx_wake_queue(netdev_get_tx_queue(
> > + ndev, q_idx));
>
> This is not indented properly, make it:
>
> if (A && B &&
> (C >
> D || E < 1))
>
> Never put operators at the beginning of a conditional line, always at the end.

I will do.

Thanks,
- Haiyang


\
 
 \ /
  Last update: 2014-03-17 22:41    [W:0.065 / U:1.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site