Messages in this thread | | | Date | Mon, 17 Mar 2014 17:56:03 +0000 | From | David Vrabel <> | Subject | Re: [Xen-devel] [PATCH] xen: declare notifier_block on xen-ops.h |
| |
On 17/03/14 07:48, Stanislaw Gruszka wrote: > Patch fixes below warnings: > > In file included from arch/x86/xen/xen-ops.h:7:0, > from arch/x86/xen/vga.c:9: >>> include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default] > void xen_resume_notifier_register(struct notifier_block *nb); > ^ >>> include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] >>> include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default] > void xen_resume_notifier_unregister(struct notifier_block *nb);
Is this a fix up to your previous "xen/acpi-processor: fix enabling interrupts on syscore_resume" patch? If so, do you mind if we squash the two commits together? So bisectability is improved.
David
| |