lkml.org 
[lkml]   [2014]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: cond_resched() and RCU CPU stall warnings
    On Mon, Mar 17, 2014 at 09:58:07AM -0700, Paul E. McKenney wrote:
    > @@ -4111,6 +4115,7 @@ int __sched __cond_resched_softirq(void)
    > {
    > BUG_ON(!in_softirq());
    >
    > + rcu_cond_resched();

    Don't you have to enable BHs before doing that? And if not; that needs a
    comment for sure! :-)

    > if (should_resched()) {
    > local_bh_enable();
    > __cond_resched();
    >


    \
     
     \ /
      Last update: 2014-03-17 19:01    [W:3.759 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site