lkml.org 
[lkml]   [2014]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/10] perf, tools: Add jsmn `jasmine' JSON parser
On 3/14/14, 8:27 PM, Andi Kleen wrote:
> On Fri, Mar 14, 2014 at 04:41:31PM -0600, David Ahern wrote:
>> On 3/14/14, 3:31 PM, Andi Kleen wrote:
>>> @@ -374,6 +376,8 @@ LIB_OBJS += $(OUTPUT)util/stat.o
>>> LIB_OBJS += $(OUTPUT)util/record.o
>>> LIB_OBJS += $(OUTPUT)util/srcline.o
>>> LIB_OBJS += $(OUTPUT)util/data.o
>>> +LIB_OBJS += $(OUTPUT)util/jsmn.o
>>> +LIB_OBJS += $(OUTPUT)util/json.o
>>>
>>> LIB_OBJS += $(OUTPUT)ui/setup.o
>>> LIB_OBJS += $(OUTPUT)ui/helpline.o
>>>
>>
>> CONFIG driven? Allow a user to omit this.
>
> Why? It has no external dependencies. AFAIK that's the only reason for configs.

We have also talked about config driven builds to allow pieces to be
omitted -- e.g., to keep binary size down for embedded systems. This is
clearly a standalone piece so why not add the config upfront now?

David



\
 
 \ /
  Last update: 2014-03-15 17:21    [W:0.054 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site