lkml.org 
[lkml]   [2014]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: android: fix coding style
On Thu, Mar 13, 2014 at 03:13:04PM +0100, mourn wrote:
>
> > The changes look good, however you should be a bit more specific about
> > what the
> > fixes are, and that you used checkpatch.pl to find them (I assume).
> >
>
> Yes, you are right. I can edit the commit log.
>
> > Also, Signed-off-by: should state your full name, which I'm also assuming
> > isn't
> > 'mourn'. Please see Documentation/SubmittingPatches.
> >
>
> I have a bit of a problem here. Some companies forbid their employees to
> openly participate in open source projects. A request to the legal
> department will take around 6 months with no hope of positive result...

Then I can not take your patch, sorry, we can not take anonymous
patches, as the documentation that describes what you mean by adding the
"Signed-off-by:" line to a patch.

good luck with your legal department,

greg k-h


\
 
 \ /
  Last update: 2014-03-15 00:41    [W:0.059 / U:1.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site