Messages in this thread Patch in this message | | | From | Andi Kleen <> | Subject | [PATCH 10/10] perf, tools, record: Always allow to overide default period v2 | Date | Fri, 14 Mar 2014 14:31:38 -0700 |
| |
From: Andi Kleen <ak@linux.intel.com>
Fix the logic to allow overriding event default periods with -c or -F on the command line. I'm not sure I understand this if() fully, but this change makes all cases I tested work (tracepoint with default, default, ,-c, -F)
This fixed specifying -c / -F with json event list events, which have a default period. It should do the same for trace point events.
Cc: fweisbec@gmail.com v2: Simplify, just change || to && Signed-off-by: Andi Kleen <ak@linux.intel.com> --- tools/perf/util/evsel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index adc94dd..417b182 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -564,7 +564,7 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) * We default some events to a 1 default interval. But keep * it a weak assumption overridable by the user. */ - if (!attr->sample_period || (opts->user_freq != UINT_MAX && + if (!attr->sample_period && (opts->user_freq != UINT_MAX && opts->user_interval != ULLONG_MAX)) { if (opts->freq) { perf_evsel__set_sample_bit(evsel, PERIOD); -- 1.8.5.3
| |