Messages in this thread | | | Date | Fri, 14 Mar 2014 22:17:40 +0100 | From | Sylwester Nawrocki <> | Subject | Re: [PATCH] [media] ov2640: add support for async device registration |
| |
Hi Josh,
On 03/14/2014 11:12 AM, Josh Wu wrote: > + clk = v4l2_clk_get(&client->dev, "mclk"); > + if (IS_ERR(clk)) > + return -EPROBE_DEFER;
You should instead make it:
return PTR_ERR(clk);
But you will need this patch for that to work: http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/clk/clk.c?id=a34cd4666f3da84228a82f70c94b8d9b692034ea
With this patch there is no need to overwrite any returned error value with EPROBE_DEFER.
> @@ -1097,23 +1106,26 @@ static int ov2640_probe(struct i2c_client *client, > v4l2_ctrl_new_std(&priv->hdl,&ov2640_ctrl_ops, > V4L2_CID_HFLIP, 0, 1, 1, 0); > priv->subdev.ctrl_handler =&priv->hdl; > - if (priv->hdl.error) > - return priv->hdl.error; > - > - priv->clk = v4l2_clk_get(&client->dev, "mclk"); > - if (IS_ERR(priv->clk)) { > - ret = PTR_ERR(priv->clk); > - goto eclkget;
-- Regards, Sylwester
| |