lkml.org 
[lkml]   [2014]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] spi: dw-mmio: add oftree support
On Fri, Mar 14, 2014 at 08:55:26AM +0000, Steffen Trumtrar wrote:
> Allow probing the dw-mmio from devicetree.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> This was tested on Socfpga and v3.14-rc6
>
> .../devicetree/bindings/spi/spi-dw-mmio.txt | 25 ++++++++++++++++++++++
> drivers/spi/spi-dw-mmio.c | 19 +++++++++++++++-
> 2 files changed, 43 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/spi/spi-dw-mmio.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-dw-mmio.txt b/Documentation/devicetree/bindings/spi/spi-dw-mmio.txt
> new file mode 100644
> index 0000000..2b9bb90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-dw-mmio.txt
> @@ -0,0 +1,25 @@
> +Synopsys DesignWare SPI master controller.
> +
> +Required properties:
> +- compatible : "snps,dw-spi-mmio"
Is there not a better name than "dw-spi-mmio"?

What's the full name of the device, as on a datasheet? Is there no model
number?

Otherwise this looks ok.

> +- reg : The register base for the controller.
> +- interrupts : One interrupt, used by the controller.
> +- #address-cells : <1>, as required by generic SPI binding.
> +- #size-cells : <0>, also as required by generic SPI binding.
> +
> +Optional properties:
> +- num-chipselects : The number of chipselects.

If this is optional, when wuold I need to set this? What's the default
assumption?

Mark: I see some bindings have "num-chipselects", and some have
"num-cs". Do you have a preferred form that people could align on?

Cheers,
Mark.


\
 
 \ /
  Last update: 2014-03-14 18:01    [W:0.045 / U:1.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site