Messages in this thread | | | Date | Fri, 14 Mar 2014 16:08:50 +0100 | From | Jan Kara <> | Subject | Re: [PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of data integrity write |
| |
On Fri 14-03-14 10:54:30, Tejun Heo wrote: > On Fri, Mar 14, 2014 at 03:52:15PM +0100, Jan Kara wrote: > > Well, for ext2, you can use ext4 kernel driver which takes care of > > REQ_FLUSH properly. For fat, you'll need to fix the fs... > > This is a bit surprising tho. Were we always like this? We never had > even stupid "flush down everything and sync"? Or is this something we > broke while morphing flush implementation several times in the past > years? It has been always like this. We could add some sending of REQ_FLUSH into generic code - like generic_file_fsync() and some similar helper for ->sync_fs(). Just someone has to do it...
Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |