Messages in this thread | | | Date | Fri, 14 Mar 2014 16:38:31 +0200 | From | Heikki Krogerus <> | Subject | Re: [PATCH V3] serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers |
| |
On Fri, Mar 14, 2014 at 12:04:00PM +0000, One Thousand Gnomes wrote: > Otherwise this looks good to me. The interface is sensible, it can be > expanded easily to other devices and device types, and the logic looks > right.
I have one concern..
I think this may be problematic when used with DMA. The burst size is usually expected to be aligned with the trigger level.
Though I don't know how big risk that actually is.
Thanks,
-- heikki
| |