lkml.org 
[lkml]   [2014]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 03/11] perf: Allow for multiple ring buffers per event
> I really don't want the multi-buffer nonsense proposed. 

> An event gets
> _1_ buffer, that's it.

But we already have multi buffer. Just profile multiple CPUs
Then you have one buffer per CPU that need to be combined.

This just has two buffers per CPU.

> That also means that if someone redirect another event into this buffer,
> it needs to just work.

All the tools already handle multiple buffers (for multi CPUs).
So they don't need it.

> And because its a perf buffer, people expect it to look like one. So
> we've got 'wrap' it.

Flushing TLBs from NMIs or irq work or any interrupt context is just
a non starter.

The start/stop hardware and create gigantic gaps was also pretty bad
and would completely change the perf format too

It seem to me you're trying to solve a non-problem.

-Andi

--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2014-03-14 15:41    [W:0.132 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site