Messages in this thread | | | Date | Fri, 14 Mar 2014 12:36:44 +0100 | From | Sebastian Hesselbarth <> | Subject | Re: [PATCH v2 1/3] ARM: dts: berlin2q: add the Marvell Armada 1500 pro |
| |
On 03/14/2014 12:32 PM, Alexandre Belloni wrote: > On 14/03/2014 at 10:31:55 +0100, Sebastian Hesselbarth wrote : >> On 03/13/2014 03:06 PM, Antoine Ténart wrote: >>> + local-timer@ad0600 { >>> + compatible = "arm,cortex-a9-twd-timer"; >>> + reg = <0xad0600 0x20>; >>> + clocks = <&sysclk>; >> >> If I understand Jisheng correctly, this should be cpuclk/3. When >> removing the clocks {} container above, please also take care of >> it. >> > > You understood correctly > >> You can do >> >> cpuclk: cpu-clock { >> compatible = "fixed-clock"; >> #clock-cells = <0>; >> clock-frequency = <1200000000>; /* <- put correct freq here */ >> }; >> >> sysclk: system-clock { >> compatible = "fixed-factor-clock"; >> #clock-cells = <0>; >> clocks = <&cpuclk>; >> clock-multi = <1>; >> clock-div = <3>; >> }; >> >> Hopefully, we'll have proper clock drivers soon so we can just replace >> referenced "fixed-*" clocks. >> > > I'm working on that, do you have some code that you can share right now ?
No, nothing specific. You can have a look at drivers/clk/mvebu/ and see how we deal with it on mvebu. For now, you can stick with bg2q and I'll see how we extend that drivers for bg2/bg2cd then.
BTW: We really enjoy having a mvebu subfolder in drivers/clk as it makes things easier. If you prepare any clk drivers for berlin, I'd suggest to put them in drivers/clk/berlin from the beginning.
Sebastian
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |