Messages in this thread | | | Date | Fri, 14 Mar 2014 12:21:55 +0100 | From | Robert Baldyga <> | Subject | Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers |
| |
Hi,
On 03/13/2014 03:09 PM, Mark Brown wrote: > On Thu, Mar 13, 2014 at 12:55:04PM +0000, Lee Jones wrote: >>> Is it necessary? If previous mfd driver has various i2c line, previous mfd driver >>> initialize regmap/i2c setting on mfd driver. >>> I'm not sure that regmap/i2c setting code move from mfd driver to each driver. >>> >>> Dear Lee Jones, >>> I need your opinion about moving regmap/i2c code from mfd driver to each driver. > >> I'd rather take advice from Mark on this one. > > I don't really case that much; I'm having a hard time seeing it as > particularly useful to do the refactoring but if it makes people > happy... Keeping things in the core would help promote reusability I > guess but I'm not sure that's likely to actually happen with this sort > of driver/device. >
If you think it's not needed, you can ignore this patch. I prepared it due to Dmitry Torokhov suggestion. If you think it's useless it doesn't make me unhappy :)
Best regards Robert Baldyga
| |