Messages in this thread | | | Date | Thu, 13 Mar 2014 12:01:58 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 3/3] x86, vdso32: handle 32 bit vDSO larger one page |
| |
On 03/13/2014 11:32 AM, Andy Lutomirski wrote: > > I don't recall anyone suggesting keeping the name. CONFIG_COMPAT_VDSO > will henceforth be a silly name, since the "compat" mode won't have a > vdso. >
Linus suggested it: > What might be acceptable then is to just keep the old config name, and > if the COMPAT_VDSO config is enabled, you just disable the non-compat > vdso. At least that way, presumably any opensuse people would have > their kernel config continue working.
...
> The consensus was that the default should be no vdso, right? My most > recent patchset calls it CONFIG_ENABLE_VDSO32_BY_DEFAULT and defaults > to n.
On any practical system, the vdso needs to be turned on -- the syscall performance difference is very significant.
>> It is important that anyone who actually cares about performance unsets >> the option. > > Should there be a warning at startup if the option is set?
Possibly. Not sure if anyone will read it.
-hpa
| |