lkml.org 
[lkml]   [2014]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/3] bridge: trigger a bridge calculation upon port changes
From
On Wed, Mar 12, 2014 at 8:15 PM, Luis R. Rodriguez
<mcgrof@do-not-panic.com> wrote:
> spin_lock_bh(&p->br->lock);
> err = br_setport(p, tb);
> + changed = br_stp_recalculate_bridge_id(p->br);

Looks like you only want to check if the mac addr gets changed here,
but br_stp_recalculate_bridge_id() does more than just checking it,
are you sure the side-effects are all what you want here?

> spin_unlock_bh(&p->br->lock);
> + if (changed)
> + call_netdevice_notifiers(NETDEV_CHANGEADDR,
> + p->br->dev);
> + netdev_update_features(p->br->dev);

I think this is supposed to be in netdev event handler of br->dev
instead of here.


\
 
 \ /
  Last update: 2014-03-13 20:02    [W:0.281 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site