Messages in this thread | | | Subject | Re: [PATCH 5/9] powerpc/85xx: disable irq by hardware when suspend for 64-bit | From | Scott Wood <> | Date | Tue, 11 Mar 2014 18:51:20 -0500 |
| |
On Fri, 2014-03-07 at 12:58 +0800, Chenhui Zhao wrote: > In 64-bit mode, kernel just clears the irq soft-enable flag > in struct paca_struct to disable external irqs. But, in > the case of suspend, irqs should be disabled by hardware. > Therefore, hook a function to ppc_md.suspend_disable_irqs > to really disable irqs. > > Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com> > --- > arch/powerpc/platforms/85xx/corenet_generic.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c > index 3fdf9f3..983d81f 100644 > --- a/arch/powerpc/platforms/85xx/corenet_generic.c > +++ b/arch/powerpc/platforms/85xx/corenet_generic.c > @@ -32,6 +32,13 @@ > #include <sysdev/fsl_pci.h> > #include "smp.h" > > +#if defined(CONFIG_PPC64) && defined(CONFIG_SUSPEND) > +static void fsl_suspend_disable_irqs(void) > +{ > + __hard_irq_disable(); > +} > +#endif
Why the underscore version? Don't you want PACA_IRQ_HARD_DIS to be set?
If hard disabling is appropriate here, shouldn't we do it in generic_suspend_disable_irqs()?
Are there any existing platforms that supply a ppc_md.suspend_disable_irqs()? I don't see any when grepping.
-Scott
| |