Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 11 Mar 2014 15:56:10 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 3/3] ktest: remove the misleading $buildonly and introduce $laststep. |
| |
On Tue, 11 Mar 2014 20:50:53 +0900 Satoru Takeuchi <satoru.takeuchi@gmail.com> wrote:
> > > I just need to test them for a bit before I push them to my kernel.org > > > repo. I don't actually have a test suite for ktest. My testing is that > > > I use ktest on a daily basis, and I just use the latest devel ktest for > > > my daily activities. If something breaks, I usually notice, unless it's > > > affects something I haven't done recently (like a bisect). > > > > I'll make and send my testsuite later. I considers that > > tools/testing/ktest/example is suitable to place it. > > Sorry, actually tools/testing/ktest/tests. > .../examples/ is for examples for configs file as written in examples/README.
If the code looks clean, I have no problems with adding it.
Perhaps call the directory "selftests" that way it wont be confusing to what is there. Especially if you add a README that states that the tests in that directory are for the purpose of testing ktest.pl itself.
-- Steve
| ![\](/images/icornerr.gif) |