lkml.org 
[lkml]   [2014]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [for-next][PATCH 08/20] tracing: Warn if a tracepoint is not set via debugfs
    On Tue, 11 Mar 2014 04:08:27 +0000 (UTC)
    Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:


    > > That's my argument.
    >
    > So basically, all we'd have to do in LTTng is to add a hash table tracking the
    > tracepoint probes which are registered, but for which there are no
    > tracepoint call sites. Whenever registration of a probe would fail due to
    > -ENODEV (assuming we unregister the probe within tracepoint.c when we return
    > -ENODEV, as you initially proposed), we would put this probe in the hash table.
    > Upon module coming, we would iterate on the module's tracepoints and check
    > if any of those match the content of the hash table, and then register the
    > probe.
    >
    > I guess I'd prefer that to the weird successful failure return value in
    > tracepoint.c.
    >

    OK, then I'll add back in the removal of the tracepoint on this error.
    Then your LTTng module can handle the tracepoints that don't exist yet.

    -- Steve


    \
     
     \ /
      Last update: 2014-03-11 22:21    [W:4.163 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site