Messages in this thread | | | Date | Tue, 11 Mar 2014 09:46:41 +0000 | From | Liviu Dudau <> | Subject | Re: [PATCH v6 6/6] pci: Add support for creating a generic host_bridge from device tree |
| |
On Tue, Mar 11, 2014 at 06:50:24AM +0000, Arnd Bergmann wrote: > On Monday 10 March 2014 21:56:00 Liviu Dudau wrote: > > > > PCI_IOBASE is always defined. See the discussion with Russell on this subject. > > > > include/asm-generic/io.h has at line 118: > > > > #ifndef PCI_IOBASE > > #define PCI_IOBASE ((void __iomem *) 0) > > #endif > > That is only defined for those that use asm-generic/pci.h, which most architectures > don't.
I think it is defined for anyone that #includes <asm-generic/io.h>. There is no other #ifdef around that.
> > > I will go with my idea tomorrow. arm64 overwrite the implementation anyway, I > > find it cleaner rather than having to do #ifdefs and/or ifs. > > I'd really hope we can get to a point where arm64 doesn't need any architecture > specific code for this. It doesn't do anything special.
I agree.
Best regards, Liviu
> > Arnd > >
-- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |