Messages in this thread | | | Date | Tue, 11 Mar 2014 09:43:39 +0100 | From | Jesper Nilsson <> | Subject | Re: [PATCH] cris: Convert ffs from an object-like macro to a function-like macro |
| |
On Mon, Mar 10, 2014 at 02:22:13PM +0100, Geert Uytterhoeven wrote: > This avoids bad interactions with code using identifiers called "ffs": > > drivers/usb/gadget/f_fs.c: In function 'ffsmod_init': > drivers/usb/gadget/f_fs.c:2693:494: error: 'ffsusb_func' undeclared (first use in this function) > drivers/usb/gadget/f_fs.c:2693:494: note: each undeclared identifier is reported only once for each function it appears in > drivers/usb/gadget/f_fs.c: In function 'ffsmod_exit': > drivers/usb/gadget/f_fs.c:2693:677: error: 'ffsusb_func' undeclared (first use in this function) > drivers/usb/gadget/f_fs.c: At top level: > drivers/usb/gadget/f_fs.c:2693:35: warning: 'kernel_ffsusb_func' defined but not used [-Wunused-variable] > drivers/usb/gadget/f_fs.c: In function 'ffsmod_init': > drivers/usb/gadget/f_fs.c:2693:15: warning: control reaches end of non-void function [-Wreturn-type]
Yup, quite right. Andrew already added it to his queue, but for the mailing archives here's my:
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
/^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com
| |