lkml.org 
[lkml]   [2014]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/9] perf tools: Add hist.percentage config option
    Date
    Add hist.percentage option for setting default value of the
    symbol_conf.filter_relative. It affects the output of various perf
    commands (like perf report, top and diff) only if filter(s) applied.

    An user can write .perfconfig file like below to show absolute
    percentage of filtered entries by default:

    $ cat ~/.perfconfig
    [hist]
    percentage = absolute

    And it can be changed through command line:

    $ perf report --percentage relative

    Acked-by: Jiri Olsa <jolsa@redhat.com>
    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    ---
    tools/perf/builtin-diff.c | 2 ++
    tools/perf/util/config.c | 4 ++++
    tools/perf/util/hist.c | 8 ++++++++
    tools/perf/util/hist.h | 1 +
    4 files changed, 15 insertions(+)

    diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
    index c903fe13c173..6ef80f22c1e2 100644
    --- a/tools/perf/builtin-diff.c
    +++ b/tools/perf/builtin-diff.c
    @@ -1134,6 +1134,8 @@ static int data_init(int argc, const char **argv)

    int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused)
    {
    + perf_config(perf_default_config, NULL);
    +
    sort_order = diff__default_sort_order;
    argc = parse_options(argc, argv, options, diff_usage, 0);

    diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
    index 3e0fdd369ccb..24519e14ac56 100644
    --- a/tools/perf/util/config.c
    +++ b/tools/perf/util/config.c
    @@ -11,6 +11,7 @@
    #include "util.h"
    #include "cache.h"
    #include "exec_cmd.h"
    +#include "util/hist.h" /* perf_hist_config */

    #define MAXNAME (256)

    @@ -355,6 +356,9 @@ int perf_default_config(const char *var, const char *value,
    if (!prefixcmp(var, "core."))
    return perf_default_core_config(var, value);

    + if (!prefixcmp(var, "hist."))
    + return perf_hist_config(var, value);
    +
    /* Add other config variables here. */
    return 0;
    }
    diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
    index 6e7eb53d4bcc..a0b32df4cd88 100644
    --- a/tools/perf/util/hist.c
    +++ b/tools/perf/util/hist.c
    @@ -956,3 +956,11 @@ int parse_filter_percentage(const struct option *opt __maybe_unused,

    return 0;
    }
    +
    +int perf_hist_config(const char *var, const char *value)
    +{
    + if (!strcmp(var, "hist.percentage"))
    + return parse_filter_percentage(NULL, value, 0);
    +
    + return 0;
    +}
    diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
    index a4ec336ae3fe..5a0343eb22e2 100644
    --- a/tools/perf/util/hist.h
    +++ b/tools/perf/util/hist.h
    @@ -258,5 +258,6 @@ unsigned int hists__sort_list_width(struct hists *hists);
    struct option;
    int parse_filter_percentage(const struct option *opt __maybe_unused,
    const char *arg, int unset __maybe_unused);
    +int perf_hist_config(const char *var, const char *value);

    #endif /* __PERF_HIST_H */
    --
    1.7.11.7


    \
     
     \ /
      Last update: 2014-03-10 09:21    [W:2.979 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site