Messages in this thread | | | Subject | Re: [PATCH] cpufreq: Reformat printk() statement | From | Joe Perches <> | Date | Mon, 10 Mar 2014 09:49:18 -0700 |
| |
On Mon, 2014-03-10 at 09:35 -0700, Sören Brinkmann wrote: > Hi Joe,
Hello Sören:
> On Sun, 2014-03-09 at 09:07PM -0700, Joe Perches wrote: > > On Mon, 2014-03-10 at 11:53 +0800, Viresh Kumar wrote: > > > On 7 March 2014 01:34, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote: > > > > Reformat a printk statement to: > > > > - use pr_warn > > > > - bring the whole string into a single line in favor of being able to > > > > grep for the message (ignoring the 80 char limit) > > > > > > > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > > [] > > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > > > A more comprehensive patch would be to: > > > > Add missing newlines > > Coalesce format fragments > > Convert printks to pr_<level> > > Align arguments > > I agree. But I didn't want to spend time on "fixing" formatting without > knowing it will be accepted. Also, I was grepping for the message I > ended up changing because on an issue I actually needed to fix. > > Do you want me to squash your changes into the patch I submitted? Or do > you wanna pick up mine and submit your patch?
What I sent incorporates your change.
If Viresh or Rafael want me to sign it, I will,
Original-patch-by: Sören Brinkmann <soren.brinkmann@xilinx.com> Signed-off-by: Joe Perches <joe@perches.com>
otherwise, feel free to resend it with your signature.
cheers, Joe
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |