Messages in this thread | | | Date | Sun, 09 Feb 2014 18:04:34 +0100 | From | Hans Verkuil <> | Subject | Re: [PATCH] [media] si4713: Remove "select SI4713" |
| |
On 02/09/2014 04:27 PM, Paul Bolle wrote: > Hans, > > On Sun, 2014-02-09 at 16:18 +0100, Hans Verkuil wrote: >> USB_SI4713 and PLATFORM_SI4713 both depend on I2C_SI4713. So the select >> should be I2C_SI4713. > > Are you sure? I've actually scanned si4713.c before submitting this > patch and I couldn't find anything in it that these other two modules > require. Have I overlooked anything?
The i2c module is loaded by v4l2_i2c_new_subdev_board().
Regards,
Hans
> >> If you can post a patch fixing that, then I'll pick >> it up for 3.14. >> >> With the addition of the USB si4713 driver things moved around and were >> renamed, and these selects were missed. > > Thanks, > > > Paul Bolle > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |