Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 19/26] drivers: isdn: Move prototype declaration to header file platform.h from diva_didd.c | Date | Fri, 7 Feb 2014 13:33:46 +0000 |
| |
From: Rashika Kheria > Move prototype declarations of function to header file > hardware/eicon/platform.h because they are used by more than one file. > > This eliminates the following warnings in hardware/eicon/diddfunc.c: > drivers/isdn/hardware/eicon/diddfunc.c:95:12: warning: no previous prototype for diddfunc_init [- > Wmissing-prototypes] > drivers/isdn/hardware/eicon/diddfunc.c:110:13: warning: no previous prototype for diddfunc_finit [- > Wmissing-prototypes] ... > diff --git a/drivers/isdn/hardware/eicon/diva_didd.c b/drivers/isdn/hardware/eicon/diva_didd.c > index fab6ccf..56d32a7 100644 > --- a/drivers/isdn/hardware/eicon/diva_didd.c > +++ b/drivers/isdn/hardware/eicon/diva_didd.c > @@ -39,9 +39,6 @@ MODULE_LICENSE("GPL"); > #define DBG_MINIMUM (DL_LOG + DL_FTL + DL_ERR) > #define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG) > > -extern int diddfunc_init(void); > -extern void diddfunc_finit(void); > - > extern void DIVA_DIDD_Read(void *, int);
You should move that one as well. There really shouldn't be 'extern' definitions for any function in any C files since you want the compiler to check they are correct when the function itself is compiled.
David
| |