lkml.org 
[lkml]   [2014]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver.
Thankyou Dave,

On 07/02/14 03:53, David Miller wrote:
> From: <srinivas.kandagatla@st.com>
> Date: Mon, 3 Feb 2014 12:01:08 +0000
>
>> + res = platform_get_resource_byname(pdev,
>> + IORESOURCE_MEM, "sti-ethconf");
>
> This is not the correct way to format multi-line function calls,
> you'll need to fix this up in this entire series.

I will fix this in next version.


>
> The arguments on the second and subsequent lines must start at
> the first column after the openning parenthesis of the function
> call. You must use the appropriate number of both space and
> TAB characters necessary to do so.
>
> If you're only using TAB characters to indent, you're doing it
> wrong.
>
> Thank you.
>
>

Thanks,
srini



\
 
 \ /
  Last update: 2014-02-07 09:21    [W:0.065 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site