Messages in this thread | | | Date | Thu, 06 Feb 2014 19:45:03 -0800 (PST) | Subject | Re: Suspected Copy Paste error in rtnl_bridge_notify | From | David Miller <> |
| |
From: Tejun Heo <tj@kernel.org> Date: Fri, 31 Jan 2014 06:47:12 -0500
>> In above code isn't code line: >> err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, dev, 0); >> should be >> err = br_dev->netdev_ops->ndo_bridge_getlink(skb, 0, 0, br_dev, 0); >> >> If this needs to be changed then please review attached patch adding this >> change.
It's not a typo, we want the actual underlying physical device.
Look at the implementations such as drivers/net/ethernet/emulex/be_main.c: be_ndo_bridge_netlink(). It's doing things like:
struct be_adapter *adapter = netdev_priv(dev);
| |