lkml.org 
[lkml]   [2014]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/51] CPU hotplug: Provide lockless versions of callback registration functions
    On 02/06, Srivatsa S. Bhat wrote:
    >
    > The following method of CPU hotplug callback registration is not safe
    > due to the possibility of an ABBA deadlock involving the cpu_add_remove_lock
    > and the cpu_hotplug.lock.

    Off-topic, but perhaps it also makes sense to add the lockdep annotations
    later, to catch other similar problems. Currently get_online_cpus() acquires
    nothing from lockdep pov.


    As for the this patch/series, personally I agree.

    Oleg.



    \
     
     \ /
      Last update: 2014-02-06 20:21    [W:2.988 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site