Messages in this thread | | | Date | Thu, 6 Feb 2014 16:29:47 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCHv2] tty: Set correct tty name in 'active' sysfs attribute |
| |
On Thu, Feb 06, 2014 at 03:27:43PM +0100, Hannes Reinecke wrote: > The 'active' sysfs attribute should refer to the currently > active tty devices the console is running on, not the currently > active console.
That's not what Documentation/ABI/sysfs-tty says: Shows the list of currently configured console devices, like 'tty1 ttyS0'. The last entry in the file is the active device connected to /dev/console. The file supports poll() to detect virtual console switches.
> The console structure doesn't refer to any device in sysfs, > only the tty the console is running on has.
That sentance doesn't make sense.
> So we need to print out the tty names in 'active', not > the console names.
But that doesn't match the documentation.
What exactly are you trying to "fix" here? What is the problem that the current file has that is broken? And as you are changing what this file means, what will break if the information in the file changes?
thanks,
greg k-h
| |