Messages in this thread | | | From | "Opensource [Adam Thomson]" <> | Subject | RE: [PATCH 0/8] da9055: Driver initialisation fixes, add DT support | Date | Thu, 6 Feb 2014 13:31:22 +0000 |
| |
On Thu, Feb 06, 2014 at 13:23:47PM +0000, Guenter Roeck wrote:
> > What I could've done is use platform_get_irq_byname() and avoided using > > regmap_irq_get_virq() as I would already have the correct VIRQ to pass to > > request_threaded_irq(), but I figured that using regmap_irq_get_virq() made > > more sense at the time, and was unable to use both. > > > > I may be missing something, but I think the problem may be that you are > doing two mappings instead of just one. I don't think you need to call > regmap_irq_get_virq() at all.
Yes, you're correct. The issue was already there in the code and I was attempting to fix it. When I made the change I figured using only regmap_irq_get_virq() was the way to go, but seems like I chose the wrong option. Will make the changes (remove regmap_irq_get_virq()), test on both DT and non-DT platforms, and then will re-submit the patches.
| |