lkml.org 
[lkml]   [2014]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[v2.6.34-stable 145/213] USB: mos7840: fix port-device leak in error path
    Date
    From: Johan Hovold <jhovold@gmail.com>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit 3eb55cc4ed88eee3b5230f66abcdbd2a91639eda upstream.

    The driver set the usb-serial port pointers to NULL on errors in attach,
    effectively preventing usb-serial core from decrementing the port ref
    counters and releasing the port devices and associated data.

    Signed-off-by: Johan Hovold <jhovold@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/usb/serial/mos7840.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
    index d891d44501f8..c55d2aa35eaa 100644
    --- a/drivers/usb/serial/mos7840.c
    +++ b/drivers/usb/serial/mos7840.c
    @@ -2565,7 +2565,6 @@ error:
    kfree(mos7840_port->ctrl_buf);
    usb_free_urb(mos7840_port->control_urb);
    kfree(mos7840_port);
    - serial->port[i] = NULL;
    }
    return status;
    }
    --
    1.8.5.2


    \
     
     \ /
      Last update: 2014-02-06 01:01    [W:4.085 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site