lkml.org 
[lkml]   [2014]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[v2.6.34-stable 030/213] atm: fix info leak via getsockname()
    Date
    From: Mathias Krause <minipli@googlemail.com>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit 3c0c5cfdcd4d69ffc4b9c0907cec99039f30a50a upstream.

    The ATM code fails to initialize the two padding bytes of struct
    sockaddr_atmpvc inserted for alignment. Add an explicit memset(0)
    before filling the structure to avoid the info leak.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    net/atm/pvc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/atm/pvc.c b/net/atm/pvc.c
    index 437ee70c5e62..db0dd47de61b 100644
    --- a/net/atm/pvc.c
    +++ b/net/atm/pvc.c
    @@ -94,6 +94,7 @@ static int pvc_getname(struct socket *sock, struct sockaddr *sockaddr,
    return -ENOTCONN;
    *sockaddr_len = sizeof(struct sockaddr_atmpvc);
    addr = (struct sockaddr_atmpvc *)sockaddr;
    + memset(addr, 0, sizeof(*addr));
    addr->sap_family = AF_ATMPVC;
    addr->sap_addr.itf = vcc->dev->number;
    addr->sap_addr.vpi = vcc->vpi;
    --
    1.8.5.2


    \
     
     \ /
      Last update: 2014-02-05 23:01    [W:4.826 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site